[vlc-devel] [PATCH] qt: Fix linking EGL from QtANGLE on windows on i386
martin at martin.st
Sat May 30 07:46:29 CEST 2020
On Fri, 22 May 2020, Martin Storsjö wrote:
> On Fri, 22 May 2020, Martin Storsjö wrote:
>> Define EGLAPI instead of KHRONOS_STATIC to indicate static
>> as defining KHRONOS_STATIC surprisingly not only affects
>> linkage, but
>> also affects the calling convention (normally the EGL
>> functions are
>> stdcall, but with KHRONOS_STATIC defined, they become
>> Alternatively, we could tweak the Qt patch for adding
>> support for
>> KHRONOS_STATIC, to not affect __stdcall. I commented on this
>> let's see if there's any response, because to me, it looks
>> like that's
>> the actual original bug.
> FWIW, I sent a fix in this form upstream as well,
> https://github.com/KhronosGroup/EGL-Registry/pull/106, let's
> see how it goes...
This got merged, so fixing it in vlc by backporting that upstream fix into
our existing contribs patch instead.
More information about the vlc-devel