[vlc-devel] [PATCH 2/2] avcodec: remove reset of AVCodecContext draw_horiz_band field

[Steve Lhomme]

LGTM. It's a user callback so we don't really need to ever touch it if 
we don't use it.

On 2020-11-01 16:14, Zhao Zhili wrote:
> Ping.
> 
>> On Oct 8, 2020, at 8:02 PM, Zhao Zhili <quinkblack at foxmail.com> wrote:
>>
>> The draw_horiz_band field is initialized to NULL by libavcodec. It
>> doesn't been modified since then, so there is no point to reset it
>> again.
>> ---
>> modules/codec/avcodec/video.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/modules/codec/avcodec/video.c b/modules/codec/avcodec/video.c
>> index 81da76ed44..89a216bf76 100644
>> --- a/modules/codec/avcodec/video.c
>> +++ b/modules/codec/avcodec/video.c
>> @@ -1667,7 +1667,6 @@ no_reuse:
>>
>>          p_sys->p_va = va;
>>          p_sys->pix_fmt = hwfmt;
>> -        p_context->draw_horiz_band = NULL;
>>          vlc_mutex_unlock(&p_sys->lock);
>>          return hwfmt;
>>      }
>> -- 
>> 2.25.1
>>
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>