[vlc-devel] [PATCH 3.0.x 0/4] Backport the RIST module

[Rémi Denis-Courmont]

Le maanantaina 2. marraskuuta 2020, 17.05.17 EET Thomas Guillem a écrit :
> Hello Rémi
> 
> On Mon, Nov 2, 2020, at 14:19, Rémi Denis-Courmont wrote:
> > Le maanantaina 2. marraskuuta 2020, 15.03.35 EET Thomas Guillem a écrit :
> > > Quoting Sergio:
> > > 
> > > "I would like to open the conversation for the backporting of the
> > > simple-profile rist modules into the next 3.x release (3.0.12).
> > > 
> > > These modules have been tried and tested for over a year on the main
> > > branch (since November 2018) and are of negligible or no risk to the
> > > stability of the build ...
> > 
> > I'll have to disagree when the module is modifying common and GUI code.
> > There are modules that actually have negligible risk because they are
> > fully self- contained, and RIST is *not* one of them.
> 
> I share your concern. Maybe we should not merge the GUI part.
> But there is still a problem about requiring a new dependency:
> bitstream.Maybe we can move the bitstream header into the rist module for
> 3.0, I don't know.

I don't really care about adding a dependency - on technical level. It can be 
a problem on a licensing level though, but probably not this specific case.

I do care about making changes to the build system, the core, the GUI, 
anything, that affects other modules. There are simply no ways to convince 
oneself that they won't add a subtle or not-so-subtle breakage in the stable 
release due to accumulated differences from the master branch - no matter how 
much the module has been allegedly testing in 4.0.

This changes both the GUI and the build system.

I understand that people want this in 3.0 rather than wait however long still 
for 4.0 to come out. But IMO, this is a case for out-of-tree module in the 
mean time.

-- 
レミ・デニ-クールモン
http://www.remlab.net/