[vlc-devel] [PATCH 3.0.x 0/4] Backport the RIST module

[Sergio M. Ammirata, Ph.D.]

Thomas, Rémi,

Here is the vlc 3.0 rist tree with 3 additional commits
that eliminate the bitstream dependency by bringing in the
inline functions into the private header. I also pre-
pended  "rist_" to all imported functions and defines to
avoid namespace collissions, now and in the future.

https://code.videolan.org/sammirata/vlc-3.0

Regards,

Sergio
-----Original Message-----
From: "Sergio M. Ammirata, Ph.D." <sergio at ammirata.net>
Reply-To: Mailing list for VLC media player developers <
vlc-devel at videolan.org>
To: Mailing list for VLC media player developers <
vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [PATCH 3.0.x 0/4] Backport the
RIST module
Date: Mon, 02 Nov 2020 15:06:47 -0500

Rémi,

The bitstream dependencies can be brought into the
library's private header, they are trivial and it will be
under 20 lines of code. The GUI part is not needed and can
be left out of the backport as well.

With these changes, the modules are 100% self contained and
do not change the GUI, core or the build system. I will add
additional patches to my tree to remove the bitstream
dependency.

Regards,

Sergio

-----Original Message-----
From: Rémi Denis-Courmont <remi at remlab.net>
Reply-To: Mailing list for VLC media player developers <
vlc-devel at videolan.org>
To: Mailing list for VLC media player developers <
vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [PATCH 3.0.x 0/4] Backport the
RIST module
Date: Mon, 02 Nov 2020 17:25:14 +0200

Le maanantaina 2. marraskuuta 2020, 17.05.17 EET Thomas
Guillem a écrit :Hello Rémi
On Mon, Nov 2, 2020, at 14:19, Rémi Denis-Courmont wrote:Le
maanantaina 2. marraskuuta 2020, 15.03.35 EET Thomas
Guillem a écrit :Quoting Sergio:
"I would like to open the conversation for the backporting
of thesimple-profile rist modules into the next 3.x release
(3.0.12).
These modules have been tried and tested for over a year on
the mainbranch (since November 2018) and are of negligible
or no risk to thestability of the build ...
I'll have to disagree when the module is modifying common
and GUI code.There are modules that actually have
negligible risk because they arefully self- contained, and
RIST is *not* one of them.
I share your concern. Maybe we should not merge the GUI
part.But there is still a problem about requiring a new
dependency:bitstream.Maybe we can move the bitstream header
into the rist module for3.0, I don't know.
I don't really care about adding a dependency - on
technical level. It can be a problem on a licensing level
though, but probably not this specific case.
I do care about making changes to the build system, the
core, the GUI, anything, that affects other modules. There
are simply no ways to convince oneself that they won't add
a subtle or not-so-subtle breakage in the stable release
due to accumulated differences from the master branch - no
matter how much the module has been allegedly testing in
4.0.
This changes both the GUI and the build system.
I understand that people want this in 3.0 rather than wait
however long still for 4.0 to come out. But IMO, this is a
case for out-of-tree module in the mean time.


_______________________________________________vlc-devel
mailing listTo unsubscribe or modify your subscription
options:https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201102/5b1543df/attachment.html>