[vlc-devel] [PATCH 1/5] macosx: store the vout_window_t in the VLCOpenGLVideoView

[Steve Lhomme]

On 2020-11-03 8:30, Rémi Denis-Courmont wrote:
> Le tiistaina 3. marraskuuta 2020, 9.14.03 EET Steve Lhomme a écrit :
>> OK I see the issue. That's because the
>> removeVoutSubview()/removeFromSuperview() are called asynchronously in
>> the Close. So the VLCOpenGLVideoView still exists for a short time after
>> the Close. An atomic bool disabling mouse handling once the Close is
>> called should be enough. It will avoid the lock that is causing the
>> deadlock.
> 
> That won't work; that's a classic ToCToU mismatch. Close might set the flag
> right after mouse handling has loaded it.

I think the second solution should work. (sending updated, uncompiled an 
untested patches)

It may not be necessary at all as Marvin has reworked the whole thing in 
a branch and Alexandre on iOS.