[vlc-devel] [PATCH v3] contrib: support CMAKE_GENERATOR other than makefile

[Alexandre Janniaux]

Hi,

On Thu, Nov 05, 2020 at 12:48:07AM +0800, Zhao Zhili wrote:
>
>
> > On Nov 5, 2020, at 12:33 AM, Alexandre Janniaux <ajanni at videolabs.io> wrote:
> >
> > Hi,
> >
> > LGTM, but why is the export CMAKE_GENERATOR needed in the
> > case of msys?
>
> commit d7fd6561bed169882b33e15a86aa7cef849a950e
> Author: Steve Lhomme <robux4 at videolabs.io>
> Date:   Wed Oct 26 17:35:05 2016 +0200
>
>     contribs: fix cmake target on Windows
>
>     On Windows cmake build for a Visual Studio target if it's installed, no matter
>     what the target we want to build. Reverting to MSys makefiles allow normal
>     autotools builds to be used
>
>     Signed-off-by: Rémi Denis-Courmont <remi at remlab.net>
>
> We can specify a default CMAKE_GENERATOR for other platforms, but I'm not
> planning to do it in this patch.

I meant, I know why it's defined in the makefile, but is there a
reason why it needs to be exported afterwards?

Regards,
--
Alexandre Janniaux
Videolabs