[vlc-devel] [PATCH 2/7] picture_pool: add the video format requested when waiting for a picture

Rémi Denis-Courmont remi at remlab.net
Fri Nov 6 18:00:52 CET 2020


Le perjantaina 6. marraskuuta 2020, 16.42.09 EET Steve Lhomme a écrit :
> In push mode it's convenient to keep the same pool of buffers when only
> small changes to the video format occur.

This makes no sense to me. In push mode, the allocator is also the format 
controller. It is free to switch pool if it needs to, or if it is simpler, or 
to keep the same pool.

The need to reallocate buffers is anyway in general dependent on the specific 
allocator/decoder, so I don't even follow how passing the format in generic 
functions helps at all.

I also cannot relate this to any plan that was agreed upon in the past.

-- 
Rémi Denis-Courmont
http://www.remlab.net/





More information about the vlc-devel mailing list