[vlc-devel] [PATCH 5/8] qt: medialib: do not fetch data on rowCount()

Romain Vimont rom1v at videolabs.io
Mon Nov 9 10:58:12 CET 2020


A call to rowCount() only needs the number of items, there is no need to
fetch the actual data.
---
 modules/gui/qt/medialibrary/mlbasemodel.hpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/gui/qt/medialibrary/mlbasemodel.hpp b/modules/gui/qt/medialibrary/mlbasemodel.hpp
index 04be2725aa..5ee4bc8026 100644
--- a/modules/gui/qt/medialibrary/mlbasemodel.hpp
+++ b/modules/gui/qt/medialibrary/mlbasemodel.hpp
@@ -150,7 +150,6 @@ public:
             vlc_mutex_locker lock( &m_item_lock );
             if ( m_initialized == false )
             {
-                m_item_list = const_cast<MLSlidingWindowModel<T>*>(this)->fetch();
                 m_total_count = countTotalElements();
                 m_initialized = true;
                 countHasChanged = true;
-- 
2.29.2



More information about the vlc-devel mailing list