[vlc-devel] [PATCH 0/8] Qt: medialib: handle medialib events from the UI thread

[Alexandre Janniaux]

Hi,

You can probably reference #22687 in your last commit. :)

Regards,
--
Alexandre Janniaux
Videolabs

On Mon, Nov 09, 2020 at 10:58:07AM +0100, Romain Vimont wrote:
> The medialib events notify changes that must be reflected in the UI, but they
> can be executed from any thread, so it is incorrect to update the UI from
> there.
>
> This is a cleaning patchset before moving database queries out of the UI thread.
>
> Romain Vimont (8):
>   qt: medialib: remove unused m_nb_max_items
>   qt: medialib: remove unused b_is_reloading
>   qt: medialib: change list visibility to private
>   qt: medialib: initialize total count
>   qt: medialib: do not fetch data on rowCount()
>   qt: medialib: simplify condition
>   qt: medialib: handle events from the UI thread
>   qt: medialib: remove synchronization
>
>  modules/gui/qt/Makefile.am                    |   1 +
>  modules/gui/qt/medialibrary/mlalbummodel.cpp  |   8 +-
>  modules/gui/qt/medialibrary/mlalbummodel.hpp  |   2 +-
>  .../gui/qt/medialibrary/mlalbumtrackmodel.cpp |  12 +-
>  .../gui/qt/medialibrary/mlalbumtrackmodel.hpp |   2 +-
>  modules/gui/qt/medialibrary/mlartistmodel.cpp |   6 +-
>  modules/gui/qt/medialibrary/mlartistmodel.hpp |   2 +-
>  modules/gui/qt/medialibrary/mlbasemodel.cpp   |  23 ++--
>  modules/gui/qt/medialibrary/mlbasemodel.hpp   |  58 +++-------
>  modules/gui/qt/medialibrary/mlevent.hpp       | 108 ++++++++++++++++++
>  modules/gui/qt/medialibrary/mlgenremodel.cpp  |   4 +-
>  modules/gui/qt/medialibrary/mlgenremodel.hpp  |   2 +-
>  .../gui/qt/medialibrary/mlrecentsmodel.cpp    |   4 +-
>  .../gui/qt/medialibrary/mlrecentsmodel.hpp    |   2 +-
>  .../qt/medialibrary/mlrecentsvideomodel.cpp   |   4 +-
>  .../qt/medialibrary/mlrecentsvideomodel.hpp   |   2 +-
>  modules/gui/qt/medialibrary/mlurlmodel.cpp    |   4 +-
>  modules/gui/qt/medialibrary/mlurlmodel.hpp    |   2 +-
>  modules/gui/qt/medialibrary/mlvideomodel.cpp  |   4 +-
>  modules/gui/qt/medialibrary/mlvideomodel.hpp  |   2 +-
>  20 files changed, 167 insertions(+), 85 deletions(-)
>  create mode 100644 modules/gui/qt/medialibrary/mlevent.hpp
>
> --
> 2.29.2
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel