[vlc-devel] [PATCH 5/5] doc: QtGl: add details on GetProcAddress impl
Alexandre Janniaux
ajanni at videolabs.io
Mon Nov 9 18:15:03 CET 2020
---
doc/libvlc/QtGL/qtvlcwidget.cpp | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/doc/libvlc/QtGL/qtvlcwidget.cpp b/doc/libvlc/QtGL/qtvlcwidget.cpp
index e33f6a6c08..f5d9adcd3c 100644
--- a/doc/libvlc/QtGL/qtvlcwidget.cpp
+++ b/doc/libvlc/QtGL/qtvlcwidget.cpp
@@ -153,6 +153,11 @@ public:
static void* get_proc_address(void* data, const char* current)
{
VLCVideo* that = static_cast<VLCVideo*>(data);
+ /* Qt usual expects core symbols to be queryable, even though it's not
+ * mentioned in the API. Cf QPlatformOpenGLContext::getProcAddress.
+ * Thus, we don't need to wrap the function symbols here, but it might
+ * fail to work (not crash though) on exotic platforms since Qt doesn't
+ * commit to this behaviour. */
return reinterpret_cast<void*>(that->mContext->getProcAddress(current));
}
--
2.29.2
More information about the vlc-devel
mailing list