[vlc-devel] [PATCH 3.0.x] macosx/build: fix compile on macOS 10.15.6

[Zhao Zhili]

> On Nov 12, 2020, at 1:50 AM, Marvin Scholz <epirat07 at gmail.com> wrote:
> 
> 
> 
> On 11 Nov 2020, at 17:44, Felix Paul Kühne wrote:
> 
>> Hello,
>> 
>>> Am 10.11.2020 um 16:30 schrieb Zhao Zhili <quinkblack at foxmail.com>:
>>> 
>>> ---
>>> extras/package/macosx/build.sh | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/extras/package/macosx/build.sh b/extras/package/macosx/build.sh
>>> index 4508354a9f..be5d449662 100755
>>> --- a/extras/package/macosx/build.sh
>>> +++ b/extras/package/macosx/build.sh
>>> @@ -10,7 +10,7 @@ info()
>>> 
>>> ARCH="x86_64"
>>> MINIMAL_OSX_VERSION="10.7"
>>> -OSX_VERSION=`xcrun --show-sdk-version`
>>> +OSX_VERSION=`xcrun --show-sdk-version |cut -d. -f1-2`
>>> OSX_KERNELVERSION=`uname -r | cut -d. -f1`
>>> SDKROOT=`xcode-select -print-path`/Platforms/MacOSX.platform/Developer/SDKs/MacOSX$OSX_VERSION.sdk
>>> VLCBUILDDIR=""
>>> —
>>> 2.28.0
>> 
>> 
>> LGTM and needs backport to 3.0.
>> 
> 
> LGTM from my side too, but shouldn't this be using  xcrun --show-sdk-path
> which seems much better approach than to try to manually put together a SDK path…

I'm not familiar about the build environment of macOS. Fill free to fix it cleanly
with a better approach.

> 
>> Best regards,
>> 
>> Felix
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel <https://mailman.videolan.org/listinfo/vlc-devel>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel <https://mailman.videolan.org/listinfo/vlc-devel>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201112/673f842f/attachment.html>