[vlc-devel] [PATCH v3 1/4] thread: add a function to give names to threads

Steve Lhomme robux4 at ycbcr.xyz
Thu Nov 12 11:17:51 CET 2020


On 2020-11-12 9:45, Rémi Denis-Courmont wrote:
> Le torstaina 12. marraskuuta 2020, 8.23.33 EET Steve Lhomme a écrit :
>>> This is not Android-specific and should be in linux/thread.c.
>>
>> It is.
> 
> No it is not. That nonportable POSIX thread extension function also exists on
> desktop Linux and even some other OSes.

But that's not what we use for Linux, nor other platforms. And I prefer 
to use the variants already used in dav1d that are known to work that 
just trying to guess which system has what hack.

> And there are no reasons to go back to the ifdef mess when we already have
> separate files for exactly this.

I did not create android/thread.c and it contains a lot of the thread 
relates APIs. Feel free to merge the code in the posix/thread.c and add 
more ifdef if you want.

This patch only matches what already exists.


More information about the vlc-devel mailing list