[vlc-devel] [PATCH VLC-3] libvlc-module: fix sout-keep longtext

[Alexandre Janniaux]

Hi,

Ping :) Do we just discard the patch in 3.0?

Regards,
--
Alexandre Janniaux
Videolabs

On Tue, Oct 27, 2020 at 04:34:00PM +0100, Alexandre Janniaux wrote:
> Hi,
>
> On Tue, Oct 27, 2020 at 04:37:02PM +0200, Rémi Denis-Courmont wrote:
> > Hi,
> >
> > Your diagnosis seems correct, but I have mixed feelings about changing a translated string in a stable release branch.
>
> Me too, but since it has never been that way it can hardly be
> seen as a regression. Either we fix it by introducing the gather
> and it might lead to regression in the code or we remove the
> bogus documentation. Keeping the string seems more misleading
> than otherwise. So that's the least compromise solution I've
> found so far. :/
>
> Regards,
> --
> Alexandre Janniaux
> Videolabs
>
> > Le 27 octobre 2020 11:09:19 GMT+02:00, Alexandre Janniaux <ajanni at videolabs.io> a écrit :
> > >The longtext help is implying that --sout-keep will automatically add
> > >the gather stream output filter which is not accurate.
> > >
> > >It has never been the case as seen in original commit adding this:
> > >4b7cff4d248bea925e6bb19157f6a65aed3f3788.
> > >---
> > > src/libvlc-module.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > >diff --git a/src/libvlc-module.c b/src/libvlc-module.c
> > >index 79dfb9d5ae..8d913c7e9b 100644
> > >--- a/src/libvlc-module.c
> > >+++ b/src/libvlc-module.c
> > >@@ -958,8 +958,7 @@ static const char *const ppsz_prefres[] = {
> > > #define SOUT_KEEP_TEXT N_("Keep stream output open" )
> > > #define SOUT_KEEP_LONGTEXT N_( \
> > >   "This allows you to keep an unique stream output instance across " \
> > >-    "multiple playlist item (automatically insert the gather stream
> > >output " \
> > >-    "if not specified)" )
> > >+    "multiple playlist item." )
> > >
> > > #define SOUT_MUX_CACHING_TEXT N_("Stream output muxer caching (ms)")
> > > #define SOUT_MUX_CACHING_LONGTEXT N_( \
> > >--
> > >2.29.1
> > >_______________________________________________
> > >vlc-devel mailing list
> > >To unsubscribe or modify your subscription options:
> > >https://mailman.videolan.org/listinfo/vlc-devel
> >
> > --
> > Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
>
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel