[vlc-devel] [PATCH v3 1/4] thread: add a function to give names to threads

[Rémi Denis-Courmont]

Le jeudi 12 novembre 2020, 12:17:51 EET Steve Lhomme a écrit :
> On 2020-11-12 9:45, Rémi Denis-Courmont wrote:
> > Le torstaina 12. marraskuuta 2020, 8.23.33 EET Steve Lhomme a écrit :
> >>> This is not Android-specific and should be in linux/thread.c.
> >> 
> >> It is.
> > 
> > No it is not. That nonportable POSIX thread extension function also exists
> > on desktop Linux and even some other OSes.
> 
> But that's not what we use for Linux, nor other platforms. And I prefer
> to use the variants already used in dav1d that are known to work that
> just trying to guess which system has what hack.

I don't give a fuck what dav1d is doing. Using prctl(), wrong, and bypassing 
the pthread API is wrong. Duplicating code is wrong. Using ifdefs when we have 
separate files is ugly and against the established practice in threading code.

And you're being self-contradictory here. The prctl(), with all its problems, 
works equally well (or equally badly) on Android as on desktop.

That's three objections. If you can't be bothered, then don't do the non-
Windows code. But "dav1d does it" is not a valid rationale.

-1

-- 
Rémi Denis-Courmont