[vlc-devel] [PATCH 1/2] video_output/interlacing: remove dead code

Steve Lhomme robux4 at ycbcr.xyz
Mon Nov 16 10:06:49 CET 2020


The has_deint value can never be true at this point.

This code is even dead in 3.0 as DeinterlaceCallback was not called in the init
either.
---
 src/video_output/interlacing.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/video_output/interlacing.c b/src/video_output/interlacing.c
index e6e422abf84..88af7e93fa5 100644
--- a/src/video_output/interlacing.c
+++ b/src/video_output/interlacing.c
@@ -147,16 +147,6 @@ void vout_InitInterlacingSupport(vout_thread_t *vout)
          }
     var_AddCallback(vout, "deinterlace-mode", DeinterlaceCallback, NULL);
 
-    /* Override the initial value from filters if present */
-    char *filter_mode = NULL;
-    if (sys->has_deint)
-        filter_mode = var_CreateGetNonEmptyString(vout, "sout-deinterlace-mode");
-    if (filter_mode) {
-        deinterlace_state = 1;
-        free(deinterlace_mode);
-        deinterlace_mode = filter_mode;
-    }
-
     /* */
     val.psz_string = deinterlace_mode ? deinterlace_mode : optm->orig.psz;
     var_Change(vout, "deinterlace-mode", VLC_VAR_SETVALUE, val);
-- 
2.26.2



More information about the vlc-devel mailing list