[vlc-devel] [PATCH v2 4/6] contrib: lua: fix CC replacement

[Alexandre Janniaux]

On Mon, Nov 16, 2020 at 07:53:59AM +0100, Steve Lhomme wrote:
> On 2020-11-14 16:30, Alexandre Janniaux wrote:
> > The sed command was replacing CC= with CC= and thus doing nothing.
>
> It's replacing CC= by #CC=, in other words commenting all the lines that
> hardcode a compiler. You're doesn't change this, just adding more text.

Ooopps, indeed, please discard this patch.

It could be possible that we want this patch without the # in
the future, to be able to have clear configure/compile times
for this contrib but we can clearly reject the problem on
upstream and wait for them to have a proper configuration step
instead.

Regards,
--
Alexandre Janniaux
Videolabs

> > ---
> >   contrib/src/lua/rules.mak | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/contrib/src/lua/rules.mak b/contrib/src/lua/rules.mak
> > index d4c8e1c4d0..491353b484 100644
> > --- a/contrib/src/lua/rules.mak
> > +++ b/contrib/src/lua/rules.mak
> > @@ -68,8 +68,8 @@ endif
> >   	# Setup the variable used by the contrib system into the lua Makefile
> >   	# and change lua library artifact to include the version, so that it
> >   	# does not conflict with a system one
> > -	cd $(UNPACK_DIR)/src && sed -i.orig \
> > -		-e 's%CC=%#CC=%' \
> > +	cd $(UNPACK_DIR)/ && sed -i.orig \
> > +		-e 's%CC=.*%#CC=$(CC)%' \
> >   		-e 's%= *strip%=$(STRIP)%' \
> >   		-e 's%= *ranlib%= $(RANLIB)%' \
> >   		-e 's%AR= *ar%AR= $(AR)%' \
> > --
> > 2.29.2
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> >
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel