[vlc-devel] [vlc-commits] thread: add a function to give names to threads

[Steve Lhomme]

On 2020-11-16 18:26, Rémi Denis-Courmont wrote:
> Le lundi 16 novembre 2020, 17:25:57 EET Steve Lhomme a écrit :
>> On 2020-11-16 15:57, Rémi Denis-Courmont wrote:
>>> Le lundi 16 novembre 2020, 09:31:52 EET Steve Lhomme a écrit :
>>>> On 2020-11-13 19:29, Rémi Denis-Courmont wrote:
>>>>> WTF? This was rejected by two people for multiple reasons.
>>>>
>>>> This was not rejected by two people.
>>>
>>> Except it was.
>>>
>>>> - Alexandre on calling pthread_setname_np because it's less code, well
>>>> no they all have different signatures
>>>
>>> Except they do. The prototype is the same on Android, glibc and NetBSD
>>> (and
>>> likely other OSes). Not that it even needs to be exactly compatible. And
>>> so
>>> at least one of Alexandre's objection remains unaddressed.
>>
>> If you quoted the commit that you probably didn't read, you would have
>> seen this:
>> * Android: pthread_setname_np(pthread_self(), buf);
> 
> Also Linux, which is what the review was about.

I explained many times why merging both implementations is wrong. Here's 
another one: we would end up with a hack for Android on multiple 
platforms. That Android hack might go away but then noone would know if 
it's safe to remove it everywhere and it would stay for no good reason 
(as seen countless times in VLC source code).

> And FWIW also OpenBSD and FreeBSD.
> 
> -1
> 
> 
>> At least they can read code.
> 
> And since you're insulting me, I'll leave it at rejected.

That's now how code review and code rejection works.