[vlc-devel] [PATCH] samba: ask for credential in case of EPERM

[Thomas Guillem]

On Wed, Nov 18, 2020, at 16:10, Rémi Denis-Courmont wrote:
> Le mercredi 18 novembre 2020, 13:07:27 EET Thomas Guillem a écrit :
> > This fix login on Windows 10 shares.
> > ---
> >  modules/access/samba.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/modules/access/samba.c b/modules/access/samba.c
> > index ff66261c25..1dc45518f0 100644
> > --- a/modules/access/samba.c
> > +++ b/modules/access/samba.c
> > @@ -297,7 +297,7 @@ static int Open(vlc_object_t *obj)
> >          is_dir = true;
> >          size = 0;
> > 
> > -        if (errno != EACCES)
> > +        if (errno != EACCES && errno != EPERM)
> >              break;
> > 
> >          errno = 0;
> 
> AFAIK, EACCES was wrong all along. But whatever, this module is broken beyond 
> repair due to limitations of libsmbclient.
> 

Should we drop it favoring libsmb2 that start to be heavily tested by android and ios users?

libsmb2 support SMB2, SMB3, encryption, signing. Plus side, the lib use O_NONBLOCK sockets and the module use the i11e API (ie. it won't timeout).

> -- 
> Rémi Denis-Courmont
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel