[vlc-devel] [PATCH] linux/thread: Use SYS_futex instead of __NR_futex

Rémi Denis-Courmont remi at remlab.net
Thu Nov 19 16:29:27 CET 2020


	Hi,

Le maanantaina 16. marraskuuta 2020, 22.21.40 EET Khem Raj a écrit :
> SYS_futex it expected from system C library.
> in glibc (/usr/include/bits/syscall.h defines it in terms of of NR_futex)
> some newer 32bit architectures e.g. riscv32 are using 64bit time_t from
> get go unlike other 32bit architectures in glibc, therefore it wont have
> NR_futex defined but just NR_futex_time64 this aliases it to NR_futex so
> that SYS_futex is then defined for rv32

That's a good point but this patch won't work if the userspace ABI uses the 
64-bit time_t on a 32-bit ISA that did start with 32-bit time_t.

I don't think the ifdefery is correct there.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the vlc-devel mailing list