[vlc-devel] [PATCH] upnp: Correct top directory url formatting

[Alaric Senat]

The url appended here is the ContrentDirectoryService's control point 
url of an upnp server.
This url is assembled upper in the code so it's probably safe to assume 
that it will looks like this:
`<http://upnp-server-ip/somepath/ContentDirectoryService>'
Which may be why the patched code was appending the url like that in 
the first place.

There are some cases where this could fail indeed but since the last 
part of the url is basically given by the upnp server description, 
these edges cases could come from a bad server configuration.

Alaric
On Thu, Nov 19, 2020 at 17:13, Rémi Denis-Courmont <remi at remlab.net> 
wrote:
> 
> Are you sure that the URL ends with either a list of parameters or a 
> path?
> There are other cases that this leaves broken. Blindly appending to a 
> URL is
> not a great idea.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201119/08ae42bb/attachment.html>