[vlc-devel] [PATCH 00/17] Restart the display module on format changes

[Rémi Denis-Courmont]

Le sunnuntaina 22. marraskuuta 2020, 11.34.17 EET Romain Vimont a écrit :
> On Sun, Nov 22, 2020 at 11:08:33AM +0200, Rémi Denis-Courmont wrote:
> > Le perjantaina 20. marraskuuta 2020, 16.44.50 EET Steve Lhomme a écrit :
> > > The display may be able to cope with the
> > > change but in case it doesn't we need to restart the display.
> > 
> > That's not how we usually solve that problem. As was already mentioned at
> > the last workshop, we already have a simple and robust solution for that,
> > that has been used for years. The display requests up-front whatever
> > format is most convenient, and lets the the filter chains figure insert
> > any necessary conversion.
> 
> That's stupid to add a converter if a filter outputs a format that can
> be handled directly by the vout display.

No. It's smart. It avoids bloating the display with conversions that would 
needed in filters anyway and duplicating code. It also avoids breaking the fine 
and simple format negotiation and chain build that we have.

> The display sometimes do not have a "most convenient format". For
> example, the OpenGL display doesn't care if it receives I420, NV12 or
> RGBA for example. Adding a converter to match the decoder format (which
> is meaningless) is a pure waste.

Lol. Native I420 in OpenGL? And you call me stupid?

-- 
Rémi Denis-Courmont
http://www.remlab.net/