[vlc-devel] [PATCH] rtp: use a consistent timeout with httpd

Andriy Gelman andriy.gelman at gmail.com
Sun Nov 22 16:56:43 CET 2020


On Sat, 21 Nov 2020 at 14:35, Andriy Gelman <andriy.gelman at gmail.com> wrote:

> On Sat, 21. Nov 20:16, Rémi Denis-Courmont wrote:
> > Le lauantaina 21. marraskuuta 2020, 19.59.12 EET Andriy Gelman a écrit :
> > > From: Andriy Gelman <andriy.gelman at gmail.com>
> > >
> > > The parameter rtsp-timeout is advertised to rtsp clients. Clients use
> > > this information to send a keep-alive message so that the connection is
> > > not closed.
> > >
> > > Currently, rtsp-timeout is set to 60 seconds but the underlying httpd
> > > timeout is hardcoded to 10 seconds in httpd_ClientInit().
> >
> > AFAIK, httpd code disables time-outs for RTSP connections
> (httpd.c:1575).
> > That's obviously wrong and it's even kinda vain, so it should be fixed.
>
> >
> > But to the point, there should not be a 10-second connection timeout, so
> I
> > don't really follow the rationale behind your patch. Furthermore, 10
> seconds
> > seems way too few for the session timeout. The current default value of
> 60
> > seconds seems much saner.
>


> No, in my testing now that path is not reached, so infinite timeout is not
> set.
> There is probably a bug somewhere in this part of the code.
>

The commit that caused the regression is
a1116cbad0504c09b85e1db518e61fc41d4e672f

--
Andriy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201122/0e3382af/attachment.html>


More information about the vlc-devel mailing list