[vlc-devel] [PATCH 4/4] libvlc: media: use vlc_atomic_rc for refcount

Hugo Beauzée-Luyssen hugo at beauzee.fr
Mon Nov 23 09:52:28 CET 2020


On Mon, Nov 23, 2020, at 8:03 AM, Steve Lhomme wrote:
> This one was not protected by a lock. Is it possible to do the calls 
> from different threads now ? Or was it broken ?
> 

I'd say it was never clearly defined. I don't see any reason not to allow it, from what I can see the media code (or what it invokes) is thread safe.
FWIW, since preparsing happens on a dedicated thread and will now release the media from that thread, the lack of mutex/atomicity now shows.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr


More information about the vlc-devel mailing list