[vlc-devel] [PATCH 17/17] video_output: restart display after filter change

[Steve Lhomme]

On 2020-11-22 10:22, Rémi Denis-Courmont wrote:
> Le perjantaina 20. marraskuuta 2020, 16.45.07 EET Steve Lhomme a écrit :
>> This is done in the vout thread loop, immediately after the filter output
>> change is detected, before processing pictures coming out of the filters.
>> The filters are untouched (not flushed).
>>
>> The new display module is created with the format coming out of the last
>> filter.
> 
> As you have pointed out yourself, this causes glitches if the windowing system
> is not capable of retaining the window content while restarting the display.
> AFAICT; without this patch, it works just fine: the conversion filter chain is
> adjusted and the display has nothing to worry about.

It doesn't work *just fine*, an extra filter is added to match the 
original display format. So any change done in the source or filters is 
canceled by that "Adding a filter to compensate for format changes".

You said yourself that the display should be restarted when the source 
changes and now you're against it because it causes glitches ?

> Of course, that assumes the display is sensibly implemented when it comes to
> picking its input format. In particular a CPU display should always request
> CPU formats and a GPU display GPU formats - memory transfer is best handled by
> conversion filters.
> 
> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>