[vlc-devel] [PATCH 00/13] Execute medialib queries out of the UI thread

[Alexandre Janniaux]

On Mon, Nov 23, 2020 at 10:09:37PM +0200, Rémi Denis-Courmont wrote:
> Le lundi 23 novembre 2020, 18:30:14 EET Romain Vimont a écrit :
> > In practice, on my computer, during medialibrary
> > indexation, it is common that VLC is frozen for tens of seconds (e.g. 45
> > seconds) on scrolling or click on a tab.
>
> Well my experience is that, if I enable the media library, VLC crashes
> immediately because of some demuxer bug. This is totally unacceptable.
>
> The root cause bug is most likely in an underlying library (and possibly
> failure of Debian to update), caused by a file in one of the standard media
> directory. Still, for the sake of reliability, it is totally insane and
> unacceptable that VLC crashes just because of a bug in a demuxer triggered by
> a file that is neither being played and in a directory that was not explicitly
> added.
>
> If this hits one out of a dozen of devs, how many million users will have VLC
> crash straight away?

As you know, this is correctly tracked as #25119 whereas this
patchset tackles #22687. From my experience, this helped
highlighting a lot of issues in the code with sanitizers, like
prefetch so it at least served a better purpose for the user,
and we probably need to have a good report system (at least for
developers) if moved to a dedicated process. This should be
discussed on the #25119 though, as it's out of scope here.

Regards,
--
Alexandre Janniaux
Videolabs