[vlc-devel] [PATCH v2 18/18] video_output: "stop" the vout on close even if there's no display

Steve Lhomme robux4 at ycbcr.xyz
Wed Nov 25 08:07:53 CET 2020


On 2020-11-24 16:28, Rémi Denis-Courmont wrote:
> Le mardi 24 novembre 2020, 12:46:41 EET Steve Lhomme a écrit :
>> We should always disable the window so it's not hanging with no display
>> module.
> 
> The code is that way because disabling an already disabled window is (or at
> least was) not defined. The window is not supposed to have been left enabled
> without a display.
> 
> This does not look right.

There might be cases where restarting the display failed. In that case 
we're stuck with a window and no display module attached to it. This is 
transparent to the vout user who will never know about that and will 
just release the vout normally when it's done.


More information about the vlc-devel mailing list