[vlc-devel] [PATCH 1/2] mp4: Return an error if there are no attachments

[Hugo Beauzée-Luyssen]

On Mon, Nov 23, 2020, at 9:18 PM, Rémi Denis-Courmont wrote:
> Le lundi 23 novembre 2020, 15:53:23 EET Hugo Beauzée-Luyssen a écrit :
> > Instead of allocating an empty array that wouldn't be freed by the core
> 
> Is there a stated rule anywhere that attachments must be non-zero? And if 
> there is, there should probably be an assertion. If there is not, then this 
> seems like a bug in the caller (though this patch is still potentially valid).

There's no clearly defined rule, no.
I'll send an additional patch to ensure the attachment array is freed even when AppendAttachment is called with an empty array and will reword this commit message.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr