[vlc-devel] [PATCH v2 00/13] Execute medialib queries out of the UI thread

Romain Vimont rom1v at videolabs.io
Thu Nov 26 17:10:32 CET 2020


v1: https://mailman.videolan.org/pipermail/vlc-devel/2020-November/140488.html

Changes since v1:
 - fix ListCacheBase/BaseListCache rename in the middle of the patchset
   (patches 5 and 11)
 - fix crash on thumbnail generated if there is no cache (patch 6)
 - make "internal" Runnable an inner-class private to AsyncTask (patch 10)
 - remove useless includes (patch 11)
 - change members visibility (patch 5)

Branch: https://code.videolan.org/rom1v/vlc/commits/asyncml.v2
Patchset diff:
    git range-diff asyncml.v1~13..asyncml.v1 asyncml.v2~13..asyncml.v2

Regards

Romain Vimont (13):
  qt: medialib: make fetch() const
  qt: medialib: remove unused get()
  qt: medialib: do not count on item()
  qt: medialib: pass explicit query parameters
  qt: medialib: introduce list cache
  qt: medialib: use list cache from MLBaseModel
  qt: medialib: pass loader via a raw pointer
  qt: medialib: implement separate data loaders
  qt: medialib: define a medialib thread pool
  qt: medialib: introduce async task
  qt: medialib: make cache load() asynchronous
  qt: medialib: make cache count() asynchronous
  qt: load QML images asynchronously

 modules/gui/qt/Makefile.am                    |   6 +
 modules/gui/qt/medialibrary/medialib.cpp      |   3 +
 modules/gui/qt/medialibrary/medialib.hpp      |   4 +
 modules/gui/qt/medialibrary/mlalbummodel.cpp  |  48 ++-
 modules/gui/qt/medialibrary/mlalbummodel.hpp  |  12 +-
 .../gui/qt/medialibrary/mlalbumtrackmodel.cpp |  62 ++--
 .../gui/qt/medialibrary/mlalbumtrackmodel.hpp |  12 +-
 modules/gui/qt/medialibrary/mlartistmodel.cpp |  61 ++--
 modules/gui/qt/medialibrary/mlartistmodel.hpp |  12 +-
 modules/gui/qt/medialibrary/mlbasemodel.cpp   |  54 ++-
 modules/gui/qt/medialibrary/mlbasemodel.hpp   | 163 +++++----
 modules/gui/qt/medialibrary/mlgenremodel.cpp  |  53 +--
 modules/gui/qt/medialibrary/mlgenremodel.hpp  |  12 +-
 modules/gui/qt/medialibrary/mlqueryparams.cpp |  14 +
 modules/gui/qt/medialibrary/mlqueryparams.hpp |  68 ++++
 .../gui/qt/medialibrary/mlrecentsmodel.cpp    |  74 ++--
 .../gui/qt/medialibrary/mlrecentsmodel.hpp    |  20 +-
 .../qt/medialibrary/mlrecentsvideomodel.cpp   |  70 ++--
 .../qt/medialibrary/mlrecentsvideomodel.hpp   |  24 +-
 modules/gui/qt/medialibrary/mlurlmodel.cpp    |  53 +--
 modules/gui/qt/medialibrary/mlurlmodel.hpp    |  12 +-
 modules/gui/qt/medialibrary/mlvideomodel.cpp  |  50 +--
 modules/gui/qt/medialibrary/mlvideomodel.hpp  |  12 +-
 .../qt/medialibrary/qml/ArtistTopBanner.qml   |   1 +
 .../qml/MusicAlbumsGridExpandDelegate.qml     |   1 +
 .../medialibrary/qml/VideoInfoExpandPanel.qml |   1 +
 modules/gui/qt/util/asynctask.hpp             | 246 +++++++++++++
 modules/gui/qt/util/listcache.hpp             | 334 ++++++++++++++++++
 modules/gui/qt/widgets/qml/RoundImage.qml     |   1 +
 29 files changed, 1196 insertions(+), 287 deletions(-)
 create mode 100644 modules/gui/qt/medialibrary/mlqueryparams.cpp
 create mode 100644 modules/gui/qt/medialibrary/mlqueryparams.hpp
 create mode 100644 modules/gui/qt/util/asynctask.hpp
 create mode 100644 modules/gui/qt/util/listcache.hpp

-- 
2.29.2



More information about the vlc-devel mailing list