[vlc-devel] [PATCH v2 00/13] Execute medialib queries out of the UI thread

[Romain Vimont]

On Thu, Nov 26, 2020 at 06:10:04PM +0100, Pierre Lamot wrote:
> On 2020-11-26 17:54, Romain Vimont wrote:
> > On Thu, Nov 26, 2020 at 05:10:32PM +0100, Romain Vimont wrote:
> > > v1: https://mailman.videolan.org/pipermail/vlc-devel/2020-November/140488.html
> > > 
> > > Changes since v1:
> > >  - fix ListCacheBase/BaseListCache rename in the middle of the
> > > patchset
> > >    (patches 5 and 11)
> > >  - fix crash on thumbnail generated if there is no cache (patch 6)
> > >  - make "internal" Runnable an inner-class private to AsyncTask
> > > (patch 10)
> > >  - remove useless includes (patch 11)
> > >  - change members visibility (patch 5)
> > 
> > I forgot to give a status about the remaining work listed in v1:
> > 
> > > There is still some work related to asynchronous loading:
> > > - the UI should show that some background tasks are running (to let
> > > the user
> > >   know that the visible data is not up-to-date)
> > 
> > I added (on a local branch) a property/signal/slot on the model to know
> > if something if some loading is pending. I don't know how we want to
> > present that in the UI, so nothing is plugged to it for now.
> 
> On the network views we have a spinner while the view is initially loading,
> we can probably have something alike when getting the initial count, though
> I expect it to take an order of magnitude less than network queries, maybe
> we can leave it empty.

Indeed, we could use a "full page" spinner for the initial count.

In addition, I think we need a more discrete loading logo somewhere when
a page is loading. But maybe it's not necessary (the placeholders might
be sufficient).

> for individual items maybe we can have a simple placeholder while the item
> is loading, bit like what youtube is doing [1]
> [1] https://i.imgur.com/s99FGrb.png

Yes, I like the idea.