[vlc-devel] [vlc-commits] cli: allow console and Unix socket modes simultaneously

Pierre Ynard linkfanel at yahoo.fr
Mon Nov 30 04:35:09 CET 2020


> cli: allow console and Unix socket modes simultaneously
> 
> This allows the interface to process commands both from the standard
> input and from incoming Unix socket clients.
> 
> This also fixes a bug where socket mode would only start if the
> standard input was a TTY or --rc-fake-tty was passed.

This sounds nice. However, before this change, probing the CLI module
would fail if no stdin TTY was available. Now if I understand correctly,
it succeeds and launches even if unusable due to no TTY (and no socket
set up). That in particular prevents fallback to a lower priority
interface module - and for example VLC probes the main interface by
priority at startup.

Shouldn't a check be added to fail if there's no input to listen on?

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."


More information about the vlc-devel mailing list