[vlc-devel] [PATCH 3/7] package/macosx: skip cache generation when cross-compiling

[David Fuhrmann]

> Am 29.11.2020 um 20:12 schrieb Felix Paul Kühne <fkuehne at videolan.org>:
> 
> From: Felix Paul Kühne <felix at feepk.net>
> 
> ---
> extras/package/macosx/package.mak | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/extras/package/macosx/package.mak b/extras/package/macosx/package.mak
> index 1423d7874e..0e60cc838a 100644
> --- a/extras/package/macosx/package.mak
> +++ b/extras/package/macosx/package.mak
> @@ -61,7 +61,11 @@ endif
> 	## Install binary
> 	cp $(prefix)/bin/vlc $@/Contents/MacOS/VLC
> 	## Generate plugin cache
> -	bin/vlc-cache-gen $@/Contents/MacOS/plugins
> +	if test "$(build)" = "$(host)"; then \
> +		bin/vlc-cache-gen $@/Contents/MacOS/plugins \

This patch has syntax issues (missing ";" ).

> +	else \
> +		echo "Cross-compilation: cache generation skipped!" ; \
> +	fi
> 	find $@ -type d -exec chmod ugo+rx '{}' \;
> 	find $@ -type f -exec chmod ugo+r '{}' \;
> 

Also, we need to generate the plugin cache, in my opinion, prior / during the release signing process. Otherwise the bundle might get corrupted (and has an invalid signature) once a plugin cache is (maybe) added later.

Is there a way to build vlc-cache-gen as a build-tool, so it can be executed on x86?

BR. David