[vlc-devel] [PATCH 0/7] Qt: client side decoration

[Alexandre Janniaux]

Hi,

On Wed, Sep 30, 2020 at 07:32:37PM +0300, Rémi Denis-Courmont wrote:
> Le keskiviikkona 30. syyskuuta 2020, 19.21.52 EEST Pierre Lamot a écrit :
> > this patchset introduce Client Side Decoration for the Qt interface
> >
> >  * CSD are optional and can be dis/enabled at startup (--no-qt-titlebar)
> >
> >  * They are disabled by default on linux and enabled on windows.
>
> AFAIK, that is not going to work. On Linux, some brain-damaged display
> managers require the application to use CSD, so you can't have a fixed default
> to turn them off.
>
> Of course, you probably shouldn't have a fixed default to turn them on either,
> since that would needlessly break the consistency of the desktop look-and-feel
> on X11 and on SSD-capable Wayland servers.

Is it a blocker? As far as I see, the policy for enabling/disabling
CSD can be separated from this patchset and we could probably just
replace the boolean into a auto/enabled/disabled parameter to be future
proof, and keep the linux auto behaviour as disabled?

Regards,
--
Alexandre Janniaux
Videolabs