[vlc-devel] [PATCH 2/2] videotoolbox: remove explicit abort error cases

[Marvin Scholz]

On 1 Oct 2020, at 14:42, Thomas Guillem wrote:

> On Thu, Oct 1, 2020, at 14:38, Marvin Scholz wrote:
>> All of these anyway fall through to default, so it is confusing to
>> list those specifically, while a lot more errors are treated as
>> reason for aborting the VideoToolbox decoding session.
>> ---
>>  modules/codec/videotoolbox.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/modules/codec/videotoolbox.c 
>> b/modules/codec/videotoolbox.c
>> index 91d9d08ff10..2f26858de4f 100644
>> --- a/modules/codec/videotoolbox.c
>> +++ b/modules/codec/videotoolbox.c
>> @@ -1758,8 +1758,6 @@ static int HandleVTStatus(decoder_t *p_dec,
>> OSStatus status,
>>              case kVTInvalidSessionErr:
>>                  *p_vtsession_status = VTSESSION_STATUS_RESTART;
>>                  break;
>> -            case -8969 /* codecBadDataErr */:
>> -            case kVTVideoDecoderBadDataErr:
>
> I don't think it's confusing. kVTVideoDecoderBadDataErr is specified 
> because we encounter it a lot. It was not always aborting in that 
> case, and I think Alex wants to change the behavior again.
>
> Other errors are not here because we never encountered them (for now)

Ok, IMO its confusing but I have no strong opinions here, if you prefer 
to keep it.

>
>
>>              default:
>>                  *p_vtsession_status = VTSESSION_STATUS_ABORT;
>>                  break;
>> -- 
>> 2.24.3 (Apple Git-128)
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel