[vlc-devel] [PATCHv3 6/7] lib: media: copy the input item

Rémi Denis-Courmont remi at remlab.net
Thu Oct 1 16:56:31 CEST 2020

Le torstaina 1. lokakuuta 2020, 17.19.02 EEST Thomas Guillem a écrit :
> > If there is an API to copy media that does not copy media, that API is
> > buggy, regardless of this patchset.
> > 
> > > > I don't really understand why you copy items.
> > > 
> > > In order to have an immutable owner.
> > 
> > And I don't understand why you have an immutable owner private data.
> > 
> > The owner ought to know to set its private data pointer before its
> > callbacks can be triggered, so there's no race (as I pointed out in the
> > review of the first version). And in any case, it has to know when the
> > callbacks can no longer be triggered to clean up the private data.
> But this is what I did in my first version, no ?

I don't know. My interactions with the first version were mostly limited to 
pointing out a mistake in the comments or documentation, AFAIR.

Реми Дёни-Курмон

More information about the vlc-devel mailing list