[vlc-devel] [PATCH 0/5] small mac prefs fixes

[Lyndon Brown]

Can these be merged please, having been approved of a week ago :)

I've re-attached the latest copy (having the commit log adjustments).


On Thu, 2020-09-24 at 11:38 +0200, Marvin Scholz wrote:
> Hi,
> 
> thanks a lot for these patches.
> I've reviewed them and tested them and the set LGTM
> except for my remarks for the first patch.
> 
> On 24 Sep 2020, at 1:04, Lyndon Brown wrote:
> 
> > a handful of small fixes for the macosx gui preferences component.
> > 
> >  1. fix for a null deref situation.
> >  2. fix for a use-after-free.
> >  3. fix relating to ModuleConfigControl stringValue.
> >  4. simplification relating to use of module_is_main().
> >  5. fix to respect hidden cat/subcat "hack", thus avoiding showing
> > options that should be hidden.
> > 
> > a little more to come later. also to follow is a commit to make the
> > hidden cat/subcat "hack" standardised.
> > 
> > patches are attached. previews emails (i'm not using git send-mail) 
> > for
> > review to follow shortly as replies.
> > 
> > please note that although i don't expect any problem, i've not
> > compiled
> > these ones. i don't have a mac, don't have any sort of cross
> > compiling
> > setup, and don't currently have CI setup on my videolan repo (could
> > use
> > help with that).
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mac1.patch
Type: text/x-patch
Size: 1306 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201002/c10be5ba/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mac2.patch
Type: text/x-patch
Size: 744 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201002/c10be5ba/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mac3.patch
Type: text/x-patch
Size: 1048 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201002/c10be5ba/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mac4.patch
Type: text/x-patch
Size: 2908 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201002/c10be5ba/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mac5.patch
Type: text/x-patch
Size: 1792 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201002/c10be5ba/attachment-0004.bin>