[vlc-devel] [PATCH 0/10] build fixes

Steve Lhomme robux4 at ycbcr.xyz
Fri Oct 2 08:57:27 CEST 2020


On 2020-10-01 19:39, Lyndon Brown wrote:
> On Thu, 2020-10-01 at 07:46 +0200, Steve Lhomme wrote:
>> Hi,
>>
>> I don't think these are "build fixes", are they ?
> 
> Maybe not the best title, no, but the files they ignore are generated
> upon building to test a change, and then impact further commits, if you
> follow my thinking. It made sufficient sense at the time.
> 
>> I think these generated files are OK in the .gitignore but I don't
>> really know if there's a policy on what we put in there or not. I
>> always
>> assumed it was left on purpose.
> 
> They're an annoyance to me personally. I use Git-Gui to manage staging
> and committing, and the presence of all these files cluttering the
> unstaged files list means that whenever I click 'stage changed' I'm
> forced to click 'no' in a dialog asking if I want to stage them. If new
> files are introduced, then it requires carefully picking through the
> list to find them.

It's possible to ignore files in git without changing the project 
.gitignore. You just add them to .git/info/exclude. I use TortoiseGit 
and it's available in the git ignore dialog box.

> The first fix for the translation issue is even more of an annoyance,
> since it not only lengthens build times but adds a bunch of modified
> files to the unstaged list, which I then have to select and do 'commit'
> -> 'reverse changes' on to clear.
> 
>> On 2020-09-30 21:11, Lyndon Brown wrote:
>>> minor update:
>>>    - moved webvtt .igitignore entries to webvtt folder.
>>>    - added one for new json module.
>>>
>>> attached, or:
>>> https://code.videolan.org/jnqnfe/vlc/-/tree/build
>>>
>>> previews to follow.
>>>
>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list