[vlc-devel] [PATCH 4/4] avcodec: remove a conditional compilation

[Zhao Zhili]

On 10/2/20 2:54 PM, Steve Lhomme wrote:
> Why is it OK to be removed ? I assumed it was added at a time some 
> ffmpeg/libav didn't have the define, which is probably not versions we 
> support anymore. But a reason in the commit log would be helpful.

OK, will add some information about the why in a new patch:

1. FF_THREAD_FRAME is in the FFmpeg code base not after 2011.

2. codec/avcodec/video.c and codec/avcodec/directx_va.c use 
FF_THREAD_FRAME directly without check.

3. FF_THREAD_FRAME is a thread type, it's not a multithreads decoding 
support flag.

>
>
> On 2020-10-01 18:37, Zhao Zhili wrote:
>> ---
>>   modules/codec/avcodec/avcodec.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/modules/codec/avcodec/avcodec.c 
>> b/modules/codec/avcodec/avcodec.c
>> index 75bb9337d7..2db8797d32 100644
>> --- a/modules/codec/avcodec/avcodec.c
>> +++ b/modules/codec/avcodec/avcodec.c
>> @@ -133,10 +133,8 @@ vlc_module_begin ()
>>       add_string( "avcodec-codec", NULL, CODEC_TEXT, CODEC_LONGTEXT, 
>> true )
>>       add_obsolete_bool( "ffmpeg-hw" ) /* removed since 2.1.0 */
>>       add_obsolete_string( "avcodec-hw" ) /* removed since 4.0.0 */
>> -#if defined(FF_THREAD_FRAME)
>>       add_obsolete_integer( "ffmpeg-threads" ) /* removed since 2.1.0 */
>>       add_integer( "avcodec-threads", 0, THREADS_TEXT, 
>> THREADS_LONGTEXT, true );
>> -#endif
>>       add_string( "avcodec-options", NULL, AV_OPTIONS_TEXT, 
>> AV_OPTIONS_LONGTEXT, true )
>>     --
>> 2.25.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel