[vlc-devel] [PATCH 0/4] header include (consistency) fixes

[Lyndon Brown]

Attached. Previews to follow.

Patches:
 1. Fixes missing vlc_mouse.h include in src/video_output/control.h
(noticed after minor reorder of includes in patch 3).
 2. Fixes cases of including "vlc_foo.h" instead of <vlc_foo.h> for
public headers.
 3. Fixes a bunch of inconsistencies of private header includes within
the core. (I've not tried tackling modules).
 4. Includes config.h via <config.h> instead of "config.h".

I've carefully tested compiling with a fresh directory after applying
each patch in turn, doing so for both building directly in source, and
then in <source>/build.

wrt. patch 3, this was done having faced confusion putting together the
patch sent in the other day that groups platform specific directories
under 'platform' within src/, which I now realise breaks building the
ability to build 'out of source' (now that I've been made aware that
out of source building is available) and needs updating accordingly. I
was confused because 1) it's not easy to discover the set of '-I'
include directories being applied to each target, 2) there's so much
inconsistency, and 3) including private headers from other src/
subdirectories by doing #include "bar/foo.h", thus relying upon the
search falling back onto a search of src/ thus matching src/bar/foo.h,
as opposed to just specifying "../bar/foo.h" is both pointlessly
inefficient and a source of confusion, at least if you don't know the
set of search paths in play.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01.patch
Type: text/x-patch
Size: 483 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201002/e9a109da/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02.patch
Type: text/x-patch
Size: 11746 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201002/e9a109da/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03.patch
Type: text/x-patch
Size: 36899 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201002/e9a109da/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 04.patch
Type: text/x-patch
Size: 471780 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201002/e9a109da/attachment-0007.bin>