[vlc-devel] [PATCH v2 3/4] avcommon: remove unreachable switch case

[Alexandre Janniaux]

Hi,

On Mon, Oct 05, 2020 at 12:03:34AM +0800, Zhao Zhili wrote:
> VLC_MSG_INFO is zero, (verbose + VLC_MSG_ERR) is greater or equal to 1.
> ---
>  modules/codec/avcodec/avcommon.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/modules/codec/avcodec/avcommon.h b/modules/codec/avcodec/avcommon.h
> index 1aaa04baed..c7c19338c0 100644
> --- a/modules/codec/avcodec/avcommon.h
> +++ b/modules/codec/avcodec/avcommon.h
> @@ -85,9 +85,6 @@ static inline void vlc_init_avutil(vlc_object_t *obj)
>          case VLC_MSG_WARN:
>              level = AV_LOG_WARNING;
>              break;
> -        case VLC_MSG_INFO:
> -            level = AV_LOG_INFO;
> -            break;
>          case VLC_MSG_DBG:
>              level = AV_LOG_VERBOSE;
>              break;
> --
> 2.25.1

We discussed this a while ago and I don't think the whole
switch is correct. avfoo logs are probably not supposed to
be displayed if VLC_MSG_DBG is not probed, but mainly it should
probably be a dedicated settings.


Regards,
--
Alexandre Janniaux
Videolabs