[vlc-devel] [PATCH 4/4] filters: add an operations structure to set the callbacks
robux4 at ycbcr.xyz
Tue Oct 6 10:36:38 CEST 2020
On 2020-10-06 10:04, Alexandre Janniaux wrote:
> On Tue, Oct 06, 2020 at 09:47:39AM +0200, Thomas Guillem wrote:
>>>> filters->ops should be mandatory no ?
>>> I think that's the case for other operations structures. So I say yes.
>> So, add an assert instead of a if ?
> I'd suggest to add it off-ML or in an additional patch given the
> patchset size. I agree with you otherwise!
> It was done like that originally because I planned a more incremental
> approach, but it was taking a lot of time.
> (basically have both version, use the ops when available, or
> the structure pointers otherwise, and remove the structure pointer
> when everything has been migrated).
> Alexandre Janniaux
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel