[vlc-devel] [PATCH] fps: clone the extra pictures we send

[Steve Lhomme]

The same picture is supposed to be filtered or rendered at a different date,
but the source pixels should be the same. The content is not going to be
changed in the pictures we output from this filter. Even blenders take care
of this in their source picture to avoid modifying pictures used by the decoder
as reference frames.
---
 modules/video_filter/fps.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/modules/video_filter/fps.c b/modules/video_filter/fps.c
index 312e0eba91b..2d5d32b1013 100644
--- a/modules/video_filter/fps.c
+++ b/modules/video_filter/fps.c
@@ -118,10 +118,7 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_picture)
         should be avoided, it's only here as filter should work in that direction too*/
     while( unlikely( (date_Get( &p_sys->next_output_pts ) + p_sys->i_output_frame_interval ) < p_picture->date ) )
     {
-        picture_t *p_tmp = NULL;
-        p_tmp = picture_NewFromFormat( &p_filter->fmt_out.video );
-
-        picture_Copy( p_tmp, p_sys->p_previous_pic);
+        picture_t *p_tmp = picture_Clone( p_sys->p_previous_pic );
         p_tmp->date = date_Get( &p_sys->next_output_pts );
 
         vlc_picture_chain_Append( &chain, p_tmp );
-- 
2.26.2