[vlc-devel] [PATCH v2 1/13] core: add config_GetTempPath()

[Lyndon Brown]

On Tue, 2020-10-06 at 08:55 +0200, Steve Lhomme wrote:
> On 2020-10-06 7:56, Lyndon Brown wrote:
> > +    return strdup("/tmp");
> 
> I'm no expert in POSIX but hardcoding a value like that doesn't seem 
> right (same for the other platforms).

For POSIX we want to check $TMPDIR and fallback to "/tmp" if unset.
Here it just starts with "/tmp", following current VLC use, with the
second patch implementing use of $TMPDIR.

I split it just so that it would be easier to drop the $TMPDIR aspect
if just a hard coded "/tmp" was wanted as before, or otherwise the two
commits could be merged in the final revision.

> > +char *config_GetTempPath(void)
> > +{
> > +    //FIXME
> > +    return NULL;
> > +}
> 
> GetTempPathW is available even in UWP. You can put the implementation
> in 
> a file built in both cases.

I've never played with UWP, but have some awareness that there are
supposedly certain restrictions that normal apps don't have. The
existing code in src/win32/dirs-uap.c does things very differently to
the alternative win32 code. Are you sure that will work?