[vlc-devel] [PATCH 1/2] CI: Add arm64 uwp job

[Steve Lhomme]

On 2020-10-06 17:49, Martin Finkel wrote:
> From: Martin Finkel <me at martinfinkel.com>
> 
> ---
>   extras/ci/gitlab-ci.yml | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/extras/ci/gitlab-ci.yml b/extras/ci/gitlab-ci.yml
> index 0f72e15d..ef561ef1 100644
> --- a/extras/ci/gitlab-ci.yml
> +++ b/extras/ci/gitlab-ci.yml
> @@ -43,6 +43,11 @@ variables:
>           HOST_ARCH: x86_64
>           TRIPLET: $HOST_ARCH-w64-mingw32
>   
> +.variables-uwp-arm64: &variables-uwp-arm64
> +        SHORTARCH: arm64
> +        HOST_ARCH: aarch64
> +        TRIPLET: $HOST_ARCH-w64-mingw32
> +
>   .variables-macos: &variables-macos
>           VLC_PATH: /Users/videolanci/sandbox/bin
>           VLC_FORCE_KERNELVERSION: 18
> @@ -154,6 +159,15 @@ uwp64-libvlc-llvm:
>           LIBVLC_EXTRA_BUILD_FLAGS: -z
>           UWP_EXTRA_BUILD_FLAGS: -u -w -x
>   
> +uwp-arm64:

Since you're only building libvlc (-z) it should have a name similar to
uwp64-libvlc-llvm

For example uwparm64-libvlc-llvm or uwp-arm64-libvlc-llvm

> +    extends: .win-common
> +    image:
> +        name: $VLC_UWP_LLVM_IMAGE
> +    variables:
> +        <<: *variables-uwp-arm64
> +        LIBVLC_EXTRA_BUILD_FLAGS: -z -c -z -d

You only need -z once.

You don't need to handle the -c here. It's handled in "win-common".

And I didn't enable PDB generation (-d) in CI because I think the 
generated PDBs don't have the proper mapping to the source directory. It 
forces opening manually each debugged file, with a mismatching path. Did 
you get this to work ?

> +        UWP_EXTRA_BUILD_FLAGS: -u -w -x
> +
>   .nightly-win-common:
>       extends: .win-common
>       only:
> -- 
> 2.25.1.windows.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>