[vlc-devel] [PATCH] fps: clone the extra pictures we send

Rémi Denis-Courmont remi at remlab.net
Wed Oct 7 19:57:27 CEST 2020

Le keskiviikkona 7. lokakuuta 2020, 8.41.26 EEST Steve Lhomme a écrit :
> On 2020-10-06 16:40, Rémi Denis-Courmont wrote:
> > Le tiistaina 6. lokakuuta 2020, 15.08.35 EEST Steve Lhomme a écrit :
> >> On 2020-10-06 13:53, Steve Lhomme wrote:
> >>> The same picture is supposed to be filtered or rendered at a different
> >>> date, but the source pixels should be the same. The content is not going
> >>> to be changed in the pictures we output from this filter. Even blenders
> >>> take care of this in their source picture to avoid modifying pictures
> >>> used by the decoder as reference frames.
> >> 
> >> It means we can use the fps even for GPU sources.
> > 
> > We can already do that. picture_Copy() calls picture_CopyPixels() which
> > calls the context copy callback. There's effectively no differences
> > between picture_Clone() and picture_Copy() for opaque pictures.
> And this has already been pointed out in the past that this is wrong.

In the context of "GPU sources", there's nothing wrong with that except the 
misnomer. We could have called the context callback clone, hold or yield, and 
it would be just fine.

> A clone and a copy are not the same for CPU pictures.

Of course. For *CPU* pictures we should avoid copying whence possible.

Rémi Denis-Courmont

More information about the vlc-devel mailing list