[vlc-devel] Releasing 3.0.12
ajanni at videolabs.io
Sun Oct 11 17:12:28 CEST 2020
The changes look good to backport but I have a few remarks:
1/ Some issues with the commit message, example:
transcode: fix broken --sout-transcode-sfilter option
the capability is "sub source" not "spu source"
this mistake came from 1f5744e9Signed-off-by: Rémi Denis-Courmont's avatarRémi Denis-Courmont <remi at remlab.net>
2/ Incorrect naming in NEWS:
* Fixed combined use-after-free and double-free bug in MacOS preferences
* Socks password and FTP module password options now actually marked as
password type options instead of simple string type.
This does not look like a security issue if it's not a path
where untrusted data is going through. It should probably be
Crash fix instead.
I'm not sure for Sock password/FTP module password options,
what is the PASSWORD type doing? Isn't it just a GUI hint?
In this case, security is not the correct place to put that
too and Misc is probably appropriate.
On Sun, Oct 11, 2020 at 02:21:32AM +0100, Lyndon Brown wrote:
> On Sat, 2020-10-10 at 09:16 +0200, Felix Paul Kühne wrote:
> > Do you have things to backport? If yes, do it :)
> I've just gone through all of the small fixes of mine that have landed
> recently to pick out those that I feel are most appropriate for and
> worthy of inclusion into 3.0, and done the backporting where they did
> not cleanly cherry-pick.
> The hashes of the 19 chosen are below, should it be useful. I've pushed
> them to the public branch linked below, along with a 20th commit
> providing a quick fix to the chromaprint module labels (part of a much
> larger set of label fixes to submit for 4.x later) since that becomes
> visible in the prefs now after one of the fixes and is particularly
> bad. I also included a 21st commit to update the news file with
> relevant entries for them.
> If it would be helpful to provide them in some other means, a set of
> attachments, a zip, an MR to your personal code.videolan.org repo, just
> let me know.
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel