[vlc-devel] [PATCH 3/6] vout: drawable: restore drawable for OS/2

KO Myung-Hun komh78 at gmail.com
Mon Oct 12 13:00:17 CEST 2020


Steve Lhomme wrote:
> On 2020-10-11 13:00, KO Myung-Hun wrote:
>> This is from commit 72c10ed11fde80.
> The current Makefile.am already builds libdrawable_plugin.la for OS/2.
> It's using the win32/drawable.c. So I think the commit title is misleading.

Because it's for Win32 not for OS/2. You made Win32-OS/2-common
drawable.c Win32-specific. I asked to split codes for two platforms, but
it was not accepted. So, I think, title has no problem. Or any suggestion ?

> Also the commit you point out just changes one line in RemoveDrawable().
> I doubt that's the commit that broke the whole thing.

I don't know what you are saying `one line'. But this patch is very
before Win32-specefic codes were added. Of course, Win32-specific codes
will do not work on OS/2.

> Your version looks a lot like the win32 but without any event loop. In
> particular it doesn't implement vout_window_ReportSize() or
> vout_window_ReportClose() which must be implemented by window modules if
> their size change or when they are closed.

Of course, original drawable.c is common for OS/2 and Win32.
Anyway, I'll try to implement them. Thanks for your advice.

KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v6.1.10 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.os2.kr/

More information about the vlc-devel mailing list