[vlc-devel] [PATCH 5/6] decoder: fix compilation on OS/2

[KO Myung-Hun]

Hi/2.

Steve Lhomme wrote:
> On 2020-10-11 13:00, KO Myung-Hun wrote:
>> -----
>> input/decoder.c: In function 'decoder_New':
>> ../include/vlc_threads.h:99:39: error: missing binary operator before
>> token "("
>>     99 | # define VLC_THREAD_PRIORITY_AUDIO   
>> MAKESHORT(PRTYD_MAXIMUM, PRTYC_REGULAR)
>>        |                                       ^~~~~~~~~
>> input/decoder.c:2048:5: note: in expansion of macro
>> 'VLC_THREAD_PRIORITY_AUDIO'
>>   2048 | #if VLC_THREAD_PRIORITY_AUDIO != VLC_THREAD_PRIORITY_VIDEO
>>        |     ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> It looks like the issue has to do with the OS/2 definition of
> VLC_THREAD_PRIORITY_AUDIO and nothing to do with the code in the core.
> 

Problem is that new core codes broke the OS/2 build. I don't think OS/2
definition is a problem.

> Same thing for patch [5/6].
> 
> Maybe the MAKESHORT macro doesn't exist ?
> 

MAKESHORT looks like:

#define MAKEUSHORT(l,h)    (((USHORT)(l)) | ((USHORT)(h))<<8)
#define MAKESHORT(l,h)     ((SHORT)MAKEUSHORT(l, h))

BTW, #if directive does not like type casting.

Anyway I updated patch.


-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v6.1.10 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.os2.kr/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-0001-decoder-fix-compilation-on-OS-2.patch
Type: application/x-patch
Size: 1849 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201012/47ac18b4/attachment.bin>