[vlc-devel] [PATCH 2/2] video_filter: remove filter function declaration

Steve Lhomme robux4 at ycbcr.xyz
Mon Oct 12 15:58:03 CEST 2020


The declaration is already generated by the helper macros.
---
 modules/video_chroma/grey_yuv.c     |  3 ---
 modules/video_chroma/i420_yuy2.c    | 10 ----------
 modules/video_chroma/i422_i420.c    |  4 ----
 modules/video_chroma/i422_yuy2.c    |  8 --------
 modules/video_chroma/yuvp.c         |  1 -
 modules/video_chroma/yuy2_i420.c    |  4 ----
 modules/video_chroma/yuy2_i422.c    |  4 ----
 modules/video_filter/adjust.c       |  2 --
 modules/video_filter/anaglyph.c     |  1 -
 modules/video_filter/antiflicker.c  |  2 --
 modules/video_filter/ball.c         |  2 --
 modules/video_filter/colorthres.c   |  2 --
 modules/video_filter/croppadd.c     |  1 -
 modules/video_filter/erase.c        |  2 --
 modules/video_filter/extract.c      |  2 --
 modules/video_filter/gaussianblur.c |  2 --
 modules/video_filter/gradfun.c      |  2 --
 modules/video_filter/gradient.c     |  2 --
 modules/video_filter/grain.c        |  2 --
 modules/video_filter/invert.c       |  1 -
 modules/video_filter/mirror.c       |  2 --
 modules/video_filter/motionblur.c   |  2 --
 modules/video_filter/posterize.c    |  2 --
 modules/video_filter/postproc.c     |  2 --
 modules/video_filter/psychedelic.c  |  2 --
 modules/video_filter/ripple.c       |  1 -
 modules/video_filter/rotate.c       |  2 --
 modules/video_filter/scale.c        |  1 -
 modules/video_filter/sepia.c        |  2 --
 modules/video_filter/sharpen.c      |  2 --
 modules/video_filter/wave.c         |  2 --
 31 files changed, 77 deletions(-)

diff --git a/modules/video_chroma/grey_yuv.c b/modules/video_chroma/grey_yuv.c
index 308bd5c24b0..6cf35a9b707 100644
--- a/modules/video_chroma/grey_yuv.c
+++ b/modules/video_chroma/grey_yuv.c
@@ -41,9 +41,6 @@
  *****************************************************************************/
 static int  Activate ( vlc_object_t * );
 
-static void GREY_I420( filter_t *, picture_t *, picture_t * );
-static void GREY_YUY2( filter_t *, picture_t *, picture_t * );
-
 /*****************************************************************************
  * Module descriptor.
  *****************************************************************************/
diff --git a/modules/video_chroma/i420_yuy2.c b/modules/video_chroma/i420_yuy2.c
index fb7a787f957..ad6359de6ff 100644
--- a/modules/video_chroma/i420_yuy2.c
+++ b/modules/video_chroma/i420_yuy2.c
@@ -62,16 +62,6 @@
  *****************************************************************************/
 static int  Activate ( vlc_object_t * );
 
-static void I420_YUY2           ( filter_t *, picture_t *, picture_t * );
-static void I420_YVYU           ( filter_t *, picture_t *, picture_t * );
-static void I420_UYVY           ( filter_t *, picture_t *, picture_t * );
-#if !defined (MODULE_NAME_IS_i420_yuy2_altivec)
-static void I420_IUYV           ( filter_t *, picture_t *, picture_t * );
-#endif
-#if defined (MODULE_NAME_IS_i420_yuy2)
-static void I420_Y211           ( filter_t *, picture_t *, picture_t * );
-#endif
-
 /*****************************************************************************
  * Module descriptor.
  *****************************************************************************/
diff --git a/modules/video_chroma/i422_i420.c b/modules/video_chroma/i422_i420.c
index 72315a8d943..ac9098efb2e 100644
--- a/modules/video_chroma/i422_i420.c
+++ b/modules/video_chroma/i422_i420.c
@@ -42,10 +42,6 @@
  *****************************************************************************/
 static int  Activate ( vlc_object_t * );
 
-static void I422_I420( filter_t *, picture_t *, picture_t * );
-static void I422_YV12( filter_t *, picture_t *, picture_t * );
-static void I422_YUVA( filter_t *, picture_t *, picture_t * );
-
 /*****************************************************************************
  * Module descriptor
  *****************************************************************************/
diff --git a/modules/video_chroma/i422_yuy2.c b/modules/video_chroma/i422_yuy2.c
index eb29dc965da..9f401ee5ab8 100644
--- a/modules/video_chroma/i422_yuy2.c
+++ b/modules/video_chroma/i422_yuy2.c
@@ -49,14 +49,6 @@
  *****************************************************************************/
 static int  Activate ( vlc_object_t * );
 
-static void I422_YUY2               ( filter_t *, picture_t *, picture_t * );
-static void I422_YVYU               ( filter_t *, picture_t *, picture_t * );
-static void I422_UYVY               ( filter_t *, picture_t *, picture_t * );
-static void I422_IUYV               ( filter_t *, picture_t *, picture_t * );
-#if defined (MODULE_NAME_IS_i422_yuy2)
-static void I422_Y211               ( filter_t *, picture_t *, picture_t * );
-#endif
-
 /*****************************************************************************
  * Module descriptor
  *****************************************************************************/
diff --git a/modules/video_chroma/yuvp.c b/modules/video_chroma/yuvp.c
index b48ead6bda7..52ba3dbad22 100644
--- a/modules/video_chroma/yuvp.c
+++ b/modules/video_chroma/yuvp.c
@@ -51,7 +51,6 @@ vlc_module_end ()
 /****************************************************************************
  * Local prototypes
  ****************************************************************************/
-static void Convert( filter_t *, picture_t *, picture_t * );
 static void Yuv2Rgb( uint8_t *r, uint8_t *g, uint8_t *b, int y1, int u1, int v1 );
 
 VIDEO_FILTER_WRAPPER( Convert )
diff --git a/modules/video_chroma/yuy2_i420.c b/modules/video_chroma/yuy2_i420.c
index fa0c3cfd570..5094feeb50b 100644
--- a/modules/video_chroma/yuy2_i420.c
+++ b/modules/video_chroma/yuy2_i420.c
@@ -41,10 +41,6 @@
  *****************************************************************************/
 static int  Activate ( vlc_object_t * );
 
-static void YUY2_I420           ( filter_t *, picture_t *, picture_t * );
-static void YVYU_I420           ( filter_t *, picture_t *, picture_t * );
-static void UYVY_I420           ( filter_t *, picture_t *, picture_t * );
-
 /*****************************************************************************
  * Module descriptor
  *****************************************************************************/
diff --git a/modules/video_chroma/yuy2_i422.c b/modules/video_chroma/yuy2_i422.c
index b35c62f84dc..cccfb10f089 100644
--- a/modules/video_chroma/yuy2_i422.c
+++ b/modules/video_chroma/yuy2_i422.c
@@ -41,10 +41,6 @@
  *****************************************************************************/
 static int  Activate ( vlc_object_t * );
 
-static void YUY2_I422           ( filter_t *, picture_t *, picture_t * );
-static void YVYU_I422           ( filter_t *, picture_t *, picture_t * );
-static void UYVY_I422           ( filter_t *, picture_t *, picture_t * );
-
 /*****************************************************************************
  * Module descriptor
  *****************************************************************************/
diff --git a/modules/video_filter/adjust.c b/modules/video_filter/adjust.c
index 8218ddcc484..c6c1cc65220 100644
--- a/modules/video_filter/adjust.c
+++ b/modules/video_filter/adjust.c
@@ -45,9 +45,7 @@
  * Local prototypes
  *****************************************************************************/
 static int  Create    ( vlc_object_t * );
-static void Destroy   ( filter_t * );
 
-static void FilterPlanar( filter_t *, picture_t *, picture_t * );
 static picture_t *FilterPacked( filter_t *, picture_t * );
 
 /*****************************************************************************
diff --git a/modules/video_filter/anaglyph.c b/modules/video_filter/anaglyph.c
index 58a6de25e1c..65c38c39359 100644
--- a/modules/video_filter/anaglyph.c
+++ b/modules/video_filter/anaglyph.c
@@ -31,7 +31,6 @@
 #include "filter_picture.h"
 
 static int Create(vlc_object_t *);
-static void Filter(filter_t *, picture_t *, picture_t *);
 static void combine_side_by_side_yuv420(picture_t *, picture_t *, int, int);
 
 #define SCHEME_TEXT N_("Color scheme")
diff --git a/modules/video_filter/antiflicker.c b/modules/video_filter/antiflicker.c
index b43cda21c2e..a4b9cb424d4 100644
--- a/modules/video_filter/antiflicker.c
+++ b/modules/video_filter/antiflicker.c
@@ -40,13 +40,11 @@
  * Local prototypes
  *****************************************************************************/
 static int GetLuminanceAvg( picture_t * p_pic );
-static void Filter( filter_t *, picture_t *, picture_t * );
 static int AntiFlickerCallback( vlc_object_t *p_this, char const *psz_var,
                            vlc_value_t oldval, vlc_value_t newval,
                            void *p_data );
 
 static int  Create    ( vlc_object_t * );
-static void Destroy   ( filter_t * );
 VIDEO_FILTER_WRAPPER_CLOSE( Filter, Destroy )
 
 #define WINDOW_TEXT N_("Window size")
diff --git a/modules/video_filter/ball.c b/modules/video_filter/ball.c
index a1429423a17..c87f7e2146b 100644
--- a/modules/video_filter/ball.c
+++ b/modules/video_filter/ball.c
@@ -73,9 +73,7 @@ enum { RED, GREEN, BLUE, WHITE };
 typedef struct filter_sys_t filter_sys_t;
 
 static int  Create    ( vlc_object_t * );
-static void Destroy   ( filter_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 VIDEO_FILTER_WRAPPER_CLOSE( Filter, Destroy )
 
 static void drawBall( filter_sys_t *p_sys, picture_t *p_outpic );
diff --git a/modules/video_filter/colorthres.c b/modules/video_filter/colorthres.c
index 90c5536cdc1..69148d02263 100644
--- a/modules/video_filter/colorthres.c
+++ b/modules/video_filter/colorthres.c
@@ -43,9 +43,7 @@
  * Local prototypes
  *****************************************************************************/
 static int  Create    ( vlc_object_t * );
-static void Destroy   ( filter_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 static picture_t *FilterPacked( filter_t *, picture_t * );
 VIDEO_FILTER_WRAPPER_CLOSE( Filter, Destroy )
 
diff --git a/modules/video_filter/croppadd.c b/modules/video_filter/croppadd.c
index 35c126cc0e8..318083b4df2 100644
--- a/modules/video_filter/croppadd.c
+++ b/modules/video_filter/croppadd.c
@@ -39,7 +39,6 @@
  ****************************************************************************/
 static int  OpenFilter ( vlc_object_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 VIDEO_FILTER_WRAPPER(Filter)
 
 #define CROPTOP_TEXT N_( "Pixels to crop from top" )
diff --git a/modules/video_filter/erase.c b/modules/video_filter/erase.c
index 83e0114d1be..618036ee5a2 100644
--- a/modules/video_filter/erase.c
+++ b/modules/video_filter/erase.c
@@ -40,9 +40,7 @@
  * Local prototypes
  *****************************************************************************/
 static int  Create    ( vlc_object_t * );
-static void Destroy   ( filter_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 static void FilterErase( filter_t *, picture_t *, picture_t * );
 static int EraseCallback( vlc_object_t *, char const *,
                           vlc_value_t, vlc_value_t, void * );
diff --git a/modules/video_filter/extract.c b/modules/video_filter/extract.c
index 8bf4fe13aea..3d9cba50eb1 100644
--- a/modules/video_filter/extract.c
+++ b/modules/video_filter/extract.c
@@ -40,9 +40,7 @@
  * Local prototypes
  *****************************************************************************/
 static int  Create      ( vlc_object_t * );
-static void Destroy     ( filter_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 static int ExtractCallback( vlc_object_t *, char const *,
                             vlc_value_t, vlc_value_t, void * );
 VIDEO_FILTER_WRAPPER_CLOSE(Filter, Destroy)
diff --git a/modules/video_filter/gaussianblur.c b/modules/video_filter/gaussianblur.c
index 472b9304ba4..10dd001bc81 100644
--- a/modules/video_filter/gaussianblur.c
+++ b/modules/video_filter/gaussianblur.c
@@ -39,7 +39,6 @@
  * Module descriptor
  *****************************************************************************/
 static int  Create    ( vlc_object_t * );
-static void Destroy   ( filter_t * );
 
 #define SIGMA_MIN (0.01)
 #define SIGMA_MAX (4096.0)
@@ -71,7 +70,6 @@ vlc_module_end ()
 /*****************************************************************************
  * Local prototypes
  *****************************************************************************/
-static void Filter( filter_t *, picture_t *, picture_t * );
 VIDEO_FILTER_WRAPPER_CLOSE(Filter, Destroy)
 
 static const char *const ppsz_filter_options[] = {
diff --git a/modules/video_filter/gradfun.c b/modules/video_filter/gradfun.c
index 4deb9f4bc06..141642a8bcb 100644
--- a/modules/video_filter/gradfun.c
+++ b/modules/video_filter/gradfun.c
@@ -40,7 +40,6 @@
  * Module descriptor
  *****************************************************************************/
 static int  Open (vlc_object_t *);
-static void Close(filter_t *);
 
 #define CFG_PREFIX "gradfun-"
 
@@ -98,7 +97,6 @@ vlc_module_end()
 #include <stdalign.h>
 #include "gradfun.h"
 
-static void Filter(filter_t *, picture_t *, picture_t *);
 static int Callback(vlc_object_t *, char const *, vlc_value_t, vlc_value_t, void *);
 VIDEO_FILTER_WRAPPER_CLOSE(Filter, Close)
 
diff --git a/modules/video_filter/gradient.c b/modules/video_filter/gradient.c
index 62c2b81437a..7acd16a0083 100644
--- a/modules/video_filter/gradient.c
+++ b/modules/video_filter/gradient.c
@@ -44,9 +44,7 @@ enum { GRADIENT, EDGE, HOUGH };
  * Local prototypes
  *****************************************************************************/
 static int  Create    ( vlc_object_t * );
-static void Destroy   ( filter_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 static int GradientCallback( vlc_object_t *, char const *,
                              vlc_value_t, vlc_value_t,
                              void * );
diff --git a/modules/video_filter/grain.c b/modules/video_filter/grain.c
index 7638c489100..024ba4c55cd 100644
--- a/modules/video_filter/grain.c
+++ b/modules/video_filter/grain.c
@@ -41,8 +41,6 @@
  * Module descriptor
  *****************************************************************************/
 static int  Open (vlc_object_t *);
-static void Close(filter_t *);
-static void Filter(filter_t *filter, picture_t *src, picture_t *dst);
 VIDEO_FILTER_WRAPPER_CLOSE(Filter, Close)
 
 #define BANK_SIZE (64)
diff --git a/modules/video_filter/invert.c b/modules/video_filter/invert.c
index b2f712de43a..c77a86d311b 100644
--- a/modules/video_filter/invert.c
+++ b/modules/video_filter/invert.c
@@ -38,7 +38,6 @@
  *****************************************************************************/
 static int  Create      ( vlc_object_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 VIDEO_FILTER_WRAPPER(Filter)
 
 /*****************************************************************************
diff --git a/modules/video_filter/mirror.c b/modules/video_filter/mirror.c
index 14ec5517d42..0d8d4c7f7ea 100644
--- a/modules/video_filter/mirror.c
+++ b/modules/video_filter/mirror.c
@@ -41,9 +41,7 @@
  * Local prototypes
  *****************************************************************************/
 static int  Create      ( vlc_object_t * );
-static void Destroy     ( filter_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 static void VerticalMirror( picture_t *, picture_t *, int plane, bool );
 static void HorizontalMirror( picture_t *, picture_t *, int, bool );
 static void PlanarVerticalMirror( picture_t *, picture_t *, int plane, bool );
diff --git a/modules/video_filter/motionblur.c b/modules/video_filter/motionblur.c
index c99d2495b61..d2235a17671 100644
--- a/modules/video_filter/motionblur.c
+++ b/modules/video_filter/motionblur.c
@@ -43,8 +43,6 @@
 typedef struct filter_sys_t filter_sys_t;
 
 static int  Create       ( vlc_object_t * );
-static void Destroy      ( filter_t * );
-static void Filter ( filter_t *, picture_t *, picture_t * );
 static void RenderBlur   ( filter_sys_t *, picture_t *, picture_t * );
 static int MotionBlurCallback( vlc_object_t *, char const *,
                                vlc_value_t, vlc_value_t, void * );
diff --git a/modules/video_filter/posterize.c b/modules/video_filter/posterize.c
index 0d974593141..1c931f829b0 100644
--- a/modules/video_filter/posterize.c
+++ b/modules/video_filter/posterize.c
@@ -41,9 +41,7 @@
  * Local prototypes
  *****************************************************************************/
 static int  Create      ( vlc_object_t * );
-static void Destroy     ( filter_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 static void PlanarYUVPosterize( picture_t *, picture_t *, int);
 static void PackedYUVPosterize( picture_t *, picture_t *, int);
 static void RVPosterize( picture_t *, picture_t *, bool, int );
diff --git a/modules/video_filter/postproc.c b/modules/video_filter/postproc.c
index 0015598126d..6f41aad0c64 100644
--- a/modules/video_filter/postproc.c
+++ b/modules/video_filter/postproc.c
@@ -54,9 +54,7 @@
  * Local prototypes
  *****************************************************************************/
 static int OpenPostproc( vlc_object_t * );
-static void ClosePostproc( filter_t * );
 
-static void PostprocPict( filter_t *, picture_t *, picture_t * );
 VIDEO_FILTER_WRAPPER_CLOSE(PostprocPict, ClosePostproc)
 
 static int PPQCallback( vlc_object_t *, char const *,
diff --git a/modules/video_filter/psychedelic.c b/modules/video_filter/psychedelic.c
index 0c0b010fa38..49d96075694 100644
--- a/modules/video_filter/psychedelic.c
+++ b/modules/video_filter/psychedelic.c
@@ -41,9 +41,7 @@
  * Local prototypes
  *****************************************************************************/
 static int  Create    ( vlc_object_t * );
-static void Destroy   ( filter_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 VIDEO_FILTER_WRAPPER_CLOSE(Filter, Destroy)
 
 /*****************************************************************************
diff --git a/modules/video_filter/ripple.c b/modules/video_filter/ripple.c
index 2db2b922211..f4bf90fb49d 100644
--- a/modules/video_filter/ripple.c
+++ b/modules/video_filter/ripple.c
@@ -42,7 +42,6 @@
  *****************************************************************************/
 static int  Create    ( vlc_object_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 VIDEO_FILTER_WRAPPER(Filter)
 
 /*****************************************************************************
diff --git a/modules/video_filter/rotate.c b/modules/video_filter/rotate.c
index b810f9e0dbe..5c470171f8b 100644
--- a/modules/video_filter/rotate.c
+++ b/modules/video_filter/rotate.c
@@ -43,9 +43,7 @@
  * Local prototypes
  *****************************************************************************/
 static int  Create    ( vlc_object_t * );
-static void Destroy   ( filter_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 static picture_t *FilterPacked( filter_t *, picture_t * );
 VIDEO_FILTER_WRAPPER_CLOSE(Filter, Destroy)
 
diff --git a/modules/video_filter/scale.c b/modules/video_filter/scale.c
index f33b8c0cb92..944ad3e1170 100644
--- a/modules/video_filter/scale.c
+++ b/modules/video_filter/scale.c
@@ -38,7 +38,6 @@
  * Local prototypes
  ****************************************************************************/
 static int  OpenFilter ( vlc_object_t * );
-static void Filter( filter_t *, picture_t *, picture_t * );
 VIDEO_FILTER_WRAPPER(Filter)
 
 /*****************************************************************************
diff --git a/modules/video_filter/sepia.c b/modules/video_filter/sepia.c
index 65f4079249f..ce4b111ece0 100644
--- a/modules/video_filter/sepia.c
+++ b/modules/video_filter/sepia.c
@@ -42,12 +42,10 @@
  * Local prototypes
  *****************************************************************************/
 static int  Create      ( vlc_object_t * );
-static void Destroy     ( filter_t * );
 
 static void RVSepia( picture_t *, picture_t *, int );
 static void PlanarI420Sepia( picture_t *, picture_t *, int);
 static void PackedYUVSepia( picture_t *, picture_t *, int);
-static void Filter( filter_t *, picture_t *, picture_t * );
 static const char *const ppsz_filter_options[] = {
     "intensity", NULL
 };
diff --git a/modules/video_filter/sharpen.c b/modules/video_filter/sharpen.c
index c8bc55622e9..e1210c1c588 100644
--- a/modules/video_filter/sharpen.c
+++ b/modules/video_filter/sharpen.c
@@ -50,9 +50,7 @@
  * Local prototypes
  *****************************************************************************/
 static int  Create    ( vlc_object_t * );
-static void Destroy   ( filter_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
 static int SharpenCallback( vlc_object_t *, char const *,
                             vlc_value_t, vlc_value_t, void * );
 VIDEO_FILTER_WRAPPER_CLOSE(Filter, Destroy)
diff --git a/modules/video_filter/wave.c b/modules/video_filter/wave.c
index e1c0f5f4f60..9a7ba896065 100644
--- a/modules/video_filter/wave.c
+++ b/modules/video_filter/wave.c
@@ -42,8 +42,6 @@
  *****************************************************************************/
 static int  Create    ( vlc_object_t * );
 
-static void Filter( filter_t *, picture_t *, picture_t * );
-
 /*****************************************************************************
  * Module descriptor
  *****************************************************************************/
-- 
2.26.2



More information about the vlc-devel mailing list