[vlc-devel] [PATCH] cli: fixup URLs passed via command-line

[Thomas Guillem]

The same problem exists with the Network stream Qt dialog.
I guess it should be the same fix as for the CLI, no?

Yes, we need to compare, every UI applications I tested do this fixup.

Should we fixup according to the url scheme?


On Mon, Oct 12, 2020, at 16:36, Rémi Denis-Courmont wrote:
> Le maanantaina 12. lokakuuta 2020, 16.52.09 EEST Romain Vimont a écrit :
> > On Mon, Oct 12, 2020 at 04:21:13PM +0300, Rémi Denis-Courmont wrote:
> > > It was already pointed out multiple times by multiple people that this
> > > doesn't work in the previous thread.
> > Hmm, that works for me.
> > 
> > Without the patch, opening an URL containing spaces did not work:
> > 
> >     ./vlc 'http://someserver/file with space.mp4'
> > 
> > With this patch, it works.
> 
> That seems like a bug. The CLI is expected to be conservative and strict and 
> throw errors on invalid parameters. And if we're going to compare with URL 
> handlers, curl does not do any weird magic in this case.
> 
> But that's moot. As pointed out multiple times in the previous thread, this 
> patch breaks tons of MRLs.
> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel