[vlc-devel] [PATCH 2/4] filters: don't call flush locally on Close

Steve Lhomme robux4 at ycbcr.xyz
Tue Oct 13 08:22:37 CEST 2020


It's done just before a filter is closed.
---
 modules/audio_filter/converter/tospdif.c       | 1 -
 modules/hw/mmal/deinterlace.c                  | 2 --
 modules/hw/vdpau/chroma.c                      | 1 -
 modules/video_filter/deinterlace/deinterlace.c | 1 -
 4 files changed, 5 deletions(-)

diff --git a/modules/audio_filter/converter/tospdif.c b/modules/audio_filter/converter/tospdif.c
index 5b0e2df8fc3..236d4a2f8b8 100644
--- a/modules/audio_filter/converter/tospdif.c
+++ b/modules/audio_filter/converter/tospdif.c
@@ -598,7 +598,6 @@ static block_t *DoWork( filter_t *p_filter, block_t *p_in_buf )
 
 static void Close( filter_t *p_filter )
 {
-    Flush( p_filter );
     free( p_filter->p_sys );
 }
 
diff --git a/modules/hw/mmal/deinterlace.c b/modules/hw/mmal/deinterlace.c
index 45df307ee6b..746f5139e74 100644
--- a/modules/hw/mmal/deinterlace.c
+++ b/modules/hw/mmal/deinterlace.c
@@ -376,8 +376,6 @@ static void CloseMmalDeinterlace(filter_t *filter)
         return;
     }
 
-    di_flush(filter);
-
     if (sys->component && sys->component->control->is_enabled)
         mmal_port_disable(sys->component->control);
 
diff --git a/modules/hw/vdpau/chroma.c b/modules/hw/vdpau/chroma.c
index bef3eda76ad..0dfc51ffad5 100644
--- a/modules/hw/vdpau/chroma.c
+++ b/modules/hw/vdpau/chroma.c
@@ -747,7 +747,6 @@ static void OutputClose(filter_t *filter)
 {
     vlc_vdp_mixer_t *sys = filter->p_sys;
 
-    Flush(filter);
     vdp_video_mixer_destroy(sys->vdp, sys->mixer);
     picture_pool_Release(sys->pool);
     vlc_video_context_Release(filter->vctx_out);
diff --git a/modules/video_filter/deinterlace/deinterlace.c b/modules/video_filter/deinterlace/deinterlace.c
index 4822377e2cb..360dd5a61c9 100644
--- a/modules/video_filter/deinterlace/deinterlace.c
+++ b/modules/video_filter/deinterlace/deinterlace.c
@@ -482,7 +482,6 @@ int Mouse( filter_t *p_filter,
  */
 static void Close( filter_t *p_filter )
 {
-    Flush( p_filter );
     free( p_filter->p_sys );
 }
 
-- 
2.26.2



More information about the vlc-devel mailing list